Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(service selection): update split duration and fetch volume when time range changes #324

Merged
merged 4 commits into from
May 15, 2024

Conversation

ivanahuckova
Copy link
Member

@ivanahuckova ivanahuckova commented May 14, 2024

This PR:

  • Improves the re-requesting of services by volume when the time range "significantly changes." More details can be found in the README. This is an initial step, and further improvements can be made over time.
  • Adds a splitDuration of 2 hours if the time range is larger than 4 hours and smaller than 1 day, ensuring metrics are loaded appropriately for these ranges
  • Adds documentation for the features in the service selection.
  • Moves the Error component to its own module.

Here example - see when volume is queries and when not (big vs small time range changes):

volume.mov

Fixes #289

@ivanahuckova ivanahuckova requested a review from a team May 14, 2024 15:25
@ivanahuckova ivanahuckova self-assigned this May 14, 2024
@gtk-grafana
Copy link
Contributor

Did a quick look and things work as expected, although this might conflict with Sven's ongoing work in #311.

I created another issue: #325 to cache the results when the text search is used, because we're hitting loki pretty hard.

@ivanahuckova
Copy link
Member Author

although this might conflict with Sven's ongoing work in #311.

I don't think it should as we are not using any variables in here.

@ivanahuckova ivanahuckova merged commit b303066 into main May 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[queries] for volume queries add splitInterval of 1h with limits (e.g. if X DAYs, split by day)
3 participants