Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fastify-cli, vite, and typescript #367

Closed
wants to merge 3 commits into from
Closed

feat: fastify-cli, vite, and typescript #367

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc10ffa
feat: fastify-cli, vite, and typescript
Bugs5382 Mar 4, 2024
5d241a1
test: update unit testing
Bugs5382 Mar 6, 2024
e003c06
feat: remove type/tap
Bugs5382 Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .taprc
View file
Open in desktop

This file was deleted.

44 changes: 22 additions & 22 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,31 +44,31 @@
},
"homepage": "https://github.com/fastify/fastify-autoload#readme",
"devDependencies": {
"@fastify/pre-commit": "^2.0.2",
"@fastify/url-data": "^5.0.0",
"@swc-node/register": "^1.5.1",
"@swc/core": "^1.2.129",
"@fastify/pre-commit": "^2.1.0",
"@fastify/url-data": "^5.4.0",
"@swc-node/register": "^1.8.0",
"@swc/core": "^1.4.2",
"@swc/register": "^0.1.9",
"@types/jest": "^29.0.0",
"@types/node": "^20.1.0",
"@types/tap": "^15.0.5",
"fastify": "^4.0.0-rc.2",
"fastify-plugin": "^4.0.0",
"jest": "^28.1.3",
"@types/jest": "^29.5.12",
"@types/node": "^20.11.24",
"@types/tap": "^15.0.11",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we even have @types/tap? Can be removed.

Copy link
Member

@climba03003 climba03003 Mar 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is used in typescript testing in v16.
https://github.com/fastify/fastify-autoload/blob/master/test/typescript/basic.ts#L1

Yes, it can be removed if we use v18

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed new version.

@Uzlopak and @climba03003 I am 100% ok for your updating the packages file for no package lock. I just now that there is a combination or a single package causing this issue. I am just not sure which package makes my testing work.

But this is where I have problems. I not always sure what to do in this case. In all my apps, I keep the packages them up to date frequently for security and just keeping the code up to date. I understand that this is a plugin need to be more universal for a bigger mass. So whatever changes you think, I will accept and then test them with my code.

"fastify": "^4.26.2",
"fastify-plugin": "^4.5.1",
"jest": "^29.7.0",
"snazzy": "^9.0.0",
"standard": "^17.0.0",
"tap": "^16.0.0",
"ts-jest": "^28.0.7",
"ts-node": "^10.4.0",
"standard": "^17.1.0",
"tap": "^18.7.0",
"ts-jest": "^29.1.2",
"ts-node": "^10.9.2",
"ts-node-dev": "^2.0.0",
"tsd": "^0.29.0",
"tsm": "^2.2.1",
"tsx": "^3.7.1",
"typescript": "^5.0.2",
"esbuild": "^0.19.2",
"esbuild-register": "^3.4.1",
"vite": "^5.0.0",
"vitest": "^0.34.1"
"tsd": "^0.30.7",
"tsm": "^2.3.0",
"tsx": "^4.7.1",
"typescript": "^5.3.3",
"esbuild": "^0.20.1",
"esbuild-register": "^3.5.0",
"vite": "^5.1.5",
"vitest": "^1.3.1"
},
"dependencies": {},
"standard": {
Expand Down
1 change: 1 addition & 0 deletions scripts/unit-typescript-esm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ const args = [
'tap',
'--node-arg=--loader=ts-node/esm',
'--node-arg=--experimental-specifier-resolution=node',
'--',
'--no-coverage',
'test/typescript-esm/*.ts'
]
Expand Down
1 change: 1 addition & 0 deletions scripts/unit-typescript-swc-node-register.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const { exec } = require('node:child_process')
const args = [
'tap',
'--node-arg=--require=@swc-node/register',
'--',
'--no-coverage',
'test/typescript/*.ts'
]
Expand Down
1 change: 1 addition & 0 deletions scripts/unit-typescript-swc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const { exec } = require('node:child_process')
const args = [
'tap',
'--node-arg=--require=@swc/register',
'--',
'--no-coverage',
'test/typescript/*.ts'
]
Expand Down
2 changes: 2 additions & 0 deletions scripts/unit-typescript-tsm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,10 @@ const { exec } = require('node:child_process')

const args = [
'tap',
'--',
'--no-ts',
'--node-arg=--require=tsm',
'--',
'--no-coverage',
'test/typescript/*.ts'
]
Expand Down
Loading