Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fastify-cli, vite, and typescript #367

Closed
wants to merge 3 commits into from

Conversation

Bugs5382
Copy link

@Bugs5382 Bugs5382 commented Mar 5, 2024

Checklist

- small app and unit tests to test functionality
- testing with fastify-cli within itself fails, but outside of it works
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont use package-lock.json. So all your "updates" for semver minor updates are not relevant. But the semver major changes are.

package.json Outdated
"jest": "^28.1.3",
"@types/jest": "^29.5.12",
"@types/node": "^20.11.24",
"@types/tap": "^15.0.11",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we even have @types/tap? Can be removed.

Copy link
Member

@climba03003 climba03003 Mar 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it is used in typescript testing in v16.
https://github.com/fastify/fastify-autoload/blob/master/test/typescript/basic.ts#L1

Yes, it can be removed if we use v18

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed new version.

@Uzlopak and @climba03003 I am 100% ok for your updating the packages file for no package lock. I just now that there is a combination or a single package causing this issue. I am just not sure which package makes my testing work.

But this is where I have problems. I not always sure what to do in this case. In all my apps, I keep the packages them up to date frequently for security and just keeping the code up to date. I understand that this is a plugin need to be more universal for a bigger mass. So whatever changes you think, I will accept and then test them with my code.

@mcollina
Copy link
Member

mcollina commented Mar 7, 2024

Please don't ties this to a fastify v5 release

@mcollina
Copy link
Member

can you please add a test?

@climba03003
Copy link
Member

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript, Vitetest, and Autoload
4 participants