fix(ci): fix some warnings as error

[Andreagit97]

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version
/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[Andreagit97]

Let's see if this is enough

[github-actions]

Perf diff from master - unit tests

     5.66%     +1.66%  [.] sinsp::next
     5.01%     -1.19%  [.] sinsp_evt::load_params
     2.91%     -1.00%  [.] scap_event_decode_params
    10.22%     -0.93%  [.] sinsp_parser::reset
     5.57%     -0.65%  [.] next
     0.80%     +0.55%  [.] sinsp_evt::get_param
     0.65%     +0.47%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find
     0.48%     +0.37%  [.] std::_Hashtable<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info>, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, libsinsp::state::dynamic_struct::field_info> >, std::__detail::_Select1st, std::equal_to<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::hash<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::find
     0.10%     +0.36%  [.] scap_cgroup_resolve_v2
     1.02%     +0.36%  [.] 0x00000000000e93f0

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0019         +0.0018           149           149           149           149
BM_sinsp_split_median                                          +0.0064         +0.0064           149           150           149           150
BM_sinsp_split_stddev                                          +0.2904         +0.2896             1             1             1             1
BM_sinsp_split_cv                                              +0.2880         +0.2873             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0244         +0.0244            47            48            47            48
BM_sinsp_concatenate_paths_relative_path_median                +0.0255         +0.0254            46            48            46            48
BM_sinsp_concatenate_paths_relative_path_stddev                -0.5314         -0.5320             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.5426         -0.5431             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0023         -0.0024            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_median                   -0.0031         -0.0031            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.0859         +0.0859             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.0885         +0.0885             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0005         +0.0004            50            50            50            50
BM_sinsp_concatenate_paths_absolute_path_median                +0.0023         +0.0023            50            50            50            50
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.0205         +0.0206             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.0201         +0.0202             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0040         +0.0040           353           354           353           354
BM_sinsp_split_container_image_median                          +0.0110         +0.0111           350           354           350           354
BM_sinsp_split_container_image_stddev                          -0.6422         -0.6423             4             2             4             2
BM_sinsp_split_container_image_cv                              -0.6436         -0.6437             0             0             0             0

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.55%. Comparing base (5b9db23) to head (20b57f7).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2062      +/-   ##
==========================================
- Coverage   73.55%   73.55%   -0.01%     
==========================================
  Files         253      253              
  Lines       31863    31863              
  Branches     5651     5642       -9     
==========================================
- Hits        23438    23437       -1     
+ Misses       8420     8399      -21     
- Partials        5       27      +22     

Flag	Coverage Δ
libsinsp	73.55% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[FedeDP]

/approve

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Andreagit97,FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[poiana]

LGTM label has been added.

Git tree hash: 8ba67bb191161dbd50523f3e26f1d60dcb8c003c