chore(ci): disable BUILD_WARNINGS_AS_ERRORS for drivers CI

[FedeDP]

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

#2053 correctly enabled BUILD_WARNINGS_AS_ERRORS for drivers CI.
But arm64 tests are failing to build with it.
Since we are near a release, i'd like to have a properly working CI for now (we can re-enable BUILD_WARNINGS_AS_ERRORS later).

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I don't really know why kernel-tests-dev and test-drivers-ppc64le jobs get triggered considering they have an

if: github.repository == 'falcosecurity/libs'

Does this PR introduce a user-facing change?:

NONE

[poiana]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [FedeDP]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[FedeDP]

/milestone 0.18.0

[github-actions]

Perf diff from master - unit tests

    10.15%     -1.07%  [.] sinsp_parser::reset
     5.63%     +0.95%  [.] sinsp::next
     2.89%     -0.76%  [.] scap_event_decode_params
     4.14%     -0.54%  [.] gzfile_read
     0.37%     +0.52%  [.] sinsp_parser::parse_open_openat_creat_exit
     0.81%     -0.49%  [.] sinsp_fdtable::find
     1.07%     -0.49%  [.] scap_event_has_large_payload
     4.97%     -0.47%  [.] sinsp_evt::load_params
     0.97%     +0.47%  [.] sinsp_parser::parse_context_switch
     2.14%     +0.45%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            -0.0000         -0.0000           149           149           149           149
BM_sinsp_split_median                                          -0.0020         -0.0021           149           148           149           148
BM_sinsp_split_stddev                                          +0.5483         +0.5484             1             2             1             2
BM_sinsp_split_cv                                              +0.5484         +0.5484             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.1164         -0.1164            47            41            47            41
BM_sinsp_concatenate_paths_relative_path_median                -0.1158         -0.1158            46            41            46            41
BM_sinsp_concatenate_paths_relative_path_stddev                -0.6127         -0.6135             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.5617         -0.5626             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     +0.0049         +0.0049            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_median                   +0.0036         +0.0036            17            17            17            17
BM_sinsp_concatenate_paths_empty_path_stddev                   +0.3430         +0.3427             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       +0.3364         +0.3361             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.1212         -0.1212            50            44            50            44
BM_sinsp_concatenate_paths_absolute_path_median                -0.1253         -0.1253            50            44            50            44
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.8038         +0.8038             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +1.0525         +1.0526             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0069         -0.0069           353           351           353           351
BM_sinsp_split_container_image_median                          -0.0011         -0.0011           350           350           350           350
BM_sinsp_split_container_image_stddev                          -0.5955         -0.5953             4             2             4             2
BM_sinsp_split_container_image_cv                              -0.5927         -0.5925             0             0             0             0

[FedeDP]

I don't really know why kernel-tests-dev and test-drivers-ppc64le jobs get triggered considering they have an

Perhaps github.repository is the target repo (ie: it works in the other way, like "do not run this job if i forked the repo").

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.55%. Comparing base (5b9db23) to head (6eafa08).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2059   +/-   ##
=======================================
  Coverage   73.55%   73.55%           
=======================================
  Files         253      253           
  Lines       31863    31863           
  Branches     5651     5636   -15     
=======================================
  Hits        23438    23438           
+ Misses       8420     8416    -4     
- Partials        5        9    +4     

Flag	Coverage Δ
libsinsp	73.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[FedeDP]

Perhaps github.repository is the target repo (ie: it works in the other way, like "do not run this job if i forked the repo").

It is :)
Opened the PR with the fix: #2060

[FedeDP]

cc @gnosek

[FedeDP]

/hold

[Andreagit97]

this should fix #2062

[FedeDP]

Oh thanks andre! Great!

[FedeDP]

/close

[poiana]

@FedeDP: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.