Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rollback to StackflowReactPlugin<T = never> #416

Merged
merged 2 commits into from
Oct 17, 2023
Merged

fix: rollback to StackflowReactPlugin<T = never> #416

merged 2 commits into from
Oct 17, 2023

Conversation

tonyfromundefined
Copy link
Member

@tonyfromundefined tonyfromundefined commented Oct 17, 2023 •
edited
Loading

When StackflowReactPlugin

If the activities type is not received through return generic T, the following problem occurs where type inference is not performed properly.
스크린샷 2023-10-17 오후 1 03 58

When StackflowReactPlugin<T>

Since the activities type is normally received through generic T, the type can be inferred normally.
스크린샷 2023-10-17 오후 1 02 44

@vercel
Copy link

vercel bot commented Oct 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
stackflow-docs ✅ Ready (Inspect) Visit Preview Oct 17, 2023 5:22am

@tonyfromundefined tonyfromundefined marked this pull request as ready for review October 17, 2023 04:06
@tonyfromundefined tonyfromundefined changed the title fix: rollback to StackflowReactPlugin<T = never> fix: rollback to StackflowReactPlugin<T = never> Oct 17, 2023
malangcat
malangcat reviewed Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@malangcat malangcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: StackflowPluginsEntry에도 제네릭이 추가되어야 하지 않을까요?

@tonyfromundefined
Copy link
Member Author

question: StackflowPluginsEntry에도 제네릭이 추가되어야 하지 않을까요?

추가했습니다! cbe5520

orionmiz
orionmiz approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@orionmiz orionmiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Cool!

@tonyfromundefined tonyfromundefined merged commit b5f6a3c into main Oct 17, 2023
4 checks passed
@tonyfromundefined tonyfromundefined deleted the rollback-generic-t branch October 17, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orionmiz orionmiz orionmiz approved these changes

@malangcat malangcat Awaiting requested review from malangcat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tonyfromundefined @orionmiz @malangcat