fix: rollback to StackflowReactPlugin<T = never> (#416)

daangn · Oct 17, 2023 · b5f6a3c · b5f6a3c · vercel · Oct 17, 2023
1 parent 662dca2
commit b5f6a3c
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/extensions/plugin-google-analytics-4/src/googleAnalyticsPlugin.tsx b/extensions/plugin-google-analytics-4/src/googleAnalyticsPlugin.tsx
@@ -29,7 +29,7 @@ export function googleAnalyticsPlugin<
   trackingId,
   userInfo,
   useTitle = false,
-}: GoogleAnalyticsPluginOptions): StackflowReactPlugin {
+}: GoogleAnalyticsPluginOptions): StackflowReactPlugin<T> {
   return () => ({
     key: "@daangn/stackflow-google-analytics-plugin",
     onInit() {

diff --git a/extensions/plugin-google-analytics-4/src/index.ts b/extensions/plugin-google-analytics-4/src/index.ts
@@ -1,2 +1,2 @@
-export * from "./googleAnalyticsPlugin";
 export { useGoogleAnalyticsContext } from "./contexts";
+export * from "./googleAnalyticsPlugin";
diff --git a/extensions/plugin-history-sync/src/historySyncPlugin.tsx b/extensions/plugin-history-sync/src/historySyncPlugin.tsx
@@ -32,7 +32,7 @@ export function historySyncPlugin<
   T extends { [activityName: string]: unknown },
 >(
   options: HistorySyncPluginOptions<Extract<keyof T, string>>,
-): StackflowReactPlugin {
+): StackflowReactPlugin<T> {
   type K = Extract<keyof T, string>;
 
   const history =

diff --git a/extensions/plugin-preload/src/pluginPreload.tsx b/extensions/plugin-preload/src/pluginPreload.tsx
@@ -20,7 +20,7 @@ export type PreloadPluginOptions<
 
 export function preloadPlugin<T extends { [activityName: string]: unknown }>(
   options: PreloadPluginOptions<T>,
-): StackflowReactPlugin {
+): StackflowReactPlugin<T> {
   return () => ({
     key: "plugin-preload",
     wrapStack({ stack }) {

diff --git a/integrations/react/src/StackflowReactPlugin.ts b/integrations/react/src/StackflowReactPlugin.ts
@@ -1,6 +1,6 @@
 import type { Activity, Stack, StackflowPlugin } from "@stackflow/core";
 
-export type StackflowReactPlugin = () => {
+export type StackflowReactPlugin<T = never> = () => {
   /**
    * Determine how to render by using the stack state
    */

diff --git a/integrations/react/src/stackflow.tsx b/integrations/react/src/stackflow.tsx
@@ -30,7 +30,7 @@ function parseActionOptions(options?: { animate?: boolean }) {
   }
 
   const isNullableAnimateOption = options.animate == null;
-  
+
   if (isNullableAnimateOption) {
     return { skipActiveState: false };
   }
@@ -43,7 +43,7 @@ export type StackComponentType = React.FC<{
 }>;
 
 type StackflowPluginsEntry<T extends BaseActivities> =
-  | StackflowReactPlugin
+  | StackflowReactPlugin<T>
   | StackflowPluginsEntry<T>[];
 
 export type StackflowOptions<T extends BaseActivities> = {