feat(plugin-basic-ui): minSafeAreaInsetTop
#402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comment on lines
111
to
114
| height: [ | ||
| `max(${globalVars.appBar.forceSafeAreaInsetTop}, constant(safe-area-inset-top))`, | ||
| `max(${globalVars.appBar.forceSafeAreaInsetTop}, env(safe-area-inset-top))`, | ||
| ], |
There was a problem hiding this comment.
max로 하는게 나은지...
CSS Variable에 empty를 넣으면 자동으로 뒤쪽이 fallback이 되는지 확인 필요-> fallback이 작동하지 않음
There was a problem hiding this comment.
- Vanilla Extract의 createGlobalThemeContract는 선언된 변수의 초기값이 없으면 안됨
- 따라서 초기값을
""로 넣어줬음. - 해당 방식에서 fallbackVar 사용하니...
""가 값으로 들어가서, env 쪽으로 fallback이 안됨 ㅠ
|
|
orionmiz
approved these changes
Jul 18, 2023
tonyfromundefined
changed the title
forceSafeAreaInsetTopminSafeAreaInsetTop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.