Skip to content

Commit

Permalink
feat(plugin-basic-ui): minSafeAreaInsetTop (#402)
Browse files Browse the repository at this point in the history
  • Loading branch information
tonyfromundefined authored Jul 18, 2023
1 parent 0a19864 commit da0f34b
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 4 deletions.
2 changes: 2 additions & 0 deletions extensions/plugin-basic-ui/src/basicUIPlugin.css.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export const globalVars = createGlobalThemeContract(
backgroundColorTransitionDuration:
"app-bar-background-color-transition-duration",
overflow: "app-bar-overflow",
minSafeAreaInsetTop: "app-bar-min-safe-area-inset-top",
},
bottomSheet: {
borderRadius: "bottom-sheet-border-radius",
Expand Down Expand Up @@ -60,6 +61,7 @@ const androidValues: GlobalVars = {
backgroundColor: "#fff",
backgroundColorTransitionDuration: "0s",
overflow: "hidden",
minSafeAreaInsetTop: "0px",
},
bottomSheet: {
borderRadius: "1rem",
Expand Down
2 changes: 2 additions & 0 deletions extensions/plugin-basic-ui/src/basicUIPlugin.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ export const basicUIPlugin: (
[css.globalVars.appBar.height]: _options.appBar?.height,
[css.globalVars.appBar.iconColor]: _options.appBar?.iconColor,
[css.globalVars.appBar.textColor]: _options.appBar?.textColor,
[css.globalVars.appBar.minSafeAreaInsetTop]:
_options.appBar?.minSafeAreaInsetTop,
[css.globalVars.bottomSheet.borderRadius]:
_options.bottomSheet?.borderRadius,
[css.globalVars.modal.borderRadius]: _options.modal?.borderRadius,
Expand Down
10 changes: 8 additions & 2 deletions extensions/plugin-basic-ui/src/components/AppBar.css.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,10 @@ export const appBar = recipe({
});

export const safeArea = style({
height: ["constant(safe-area-inset-top)", "env(safe-area-inset-top)"],
height: [
`max(${globalVars.appBar.minSafeAreaInsetTop}, constant(safe-area-inset-top))`,
`max(${globalVars.appBar.minSafeAreaInsetTop}, env(safe-area-inset-top))`,
],
});

export const container = style([
Expand Down Expand Up @@ -191,7 +194,10 @@ export const centerMain = recipe({
left: "50%",
transform: "translate(-50%)",
height: globalVars.appBar.height,
top: ["constant(safe-area-inset-top)", "env(safe-area-inset-top)"],
top: [
`max(${globalVars.appBar.minSafeAreaInsetTop}, constant(safe-area-inset-top))`,
`max(${globalVars.appBar.minSafeAreaInsetTop}, env(safe-area-inset-top))`,
],
},
},
},
Expand Down
4 changes: 2 additions & 2 deletions extensions/plugin-basic-ui/src/components/AppScreen.css.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,10 +125,10 @@ export const paper = recipe({
paddingTop: globalVars.appBar.height,
"@supports": {
"(padding-top: constant(safe-area-inset-top))": {
paddingTop: `calc(${globalVars.appBar.height} + constant(safe-area-inset-top))`,
paddingTop: `calc(${globalVars.appBar.height} + max(${globalVars.appBar.minSafeAreaInsetTop}, constant(safe-area-inset-top)))`,
},
"(padding-top: env(safe-area-inset-top))": {
paddingTop: `calc(${globalVars.appBar.height} + env(safe-area-inset-top))`,
paddingTop: `calc(${globalVars.appBar.height} + max(${globalVars.appBar.minSafeAreaInsetTop}, env(safe-area-inset-top)))`,
},
},
},
Expand Down

1 comment on commit da0f34b

@vercel
Copy link

@vercel vercel bot commented on da0f34b Jul 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.