refactor(stackflow): Refactoring stackflow (#404)

daangn · Aug 1, 2023 · ecf46e6 · ecf46e6 · vercel · Aug 1, 2023
1 parent da0f34b
commit ecf46e6
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 12 deletions.
diff --git a/extensions/plugin-google-analytics-4/src/googleAnalyticsPlugin.tsx b/extensions/plugin-google-analytics-4/src/googleAnalyticsPlugin.tsx
@@ -29,7 +29,7 @@ export function googleAnalyticsPlugin<
   trackingId,
   userInfo,
   useTitle = false,
-}: GoogleAnalyticsPluginOptions): StackflowReactPlugin<T> {
+}: GoogleAnalyticsPluginOptions): StackflowReactPlugin {
   return () => ({
     key: "@daangn/stackflow-google-analytics-plugin",
     onInit() {

diff --git a/extensions/plugin-history-sync/src/historySyncPlugin.tsx b/extensions/plugin-history-sync/src/historySyncPlugin.tsx
@@ -32,7 +32,7 @@ export function historySyncPlugin<
   T extends { [activityName: string]: unknown },
 >(
   options: HistorySyncPluginOptions<Extract<keyof T, string>>,
-): StackflowReactPlugin<T> {
+): StackflowReactPlugin {
   type K = Extract<keyof T, string>;
 
   const history =

diff --git a/extensions/plugin-preload/src/pluginPreload.tsx b/extensions/plugin-preload/src/pluginPreload.tsx
@@ -20,7 +20,7 @@ export type PreloadPluginOptions<
 
 export function preloadPlugin<T extends { [activityName: string]: unknown }>(
   options: PreloadPluginOptions<T>,
-): StackflowReactPlugin<T> {
+): StackflowReactPlugin {
   return () => ({
     key: "plugin-preload",
     wrapStack({ stack }) {

diff --git a/integrations/react/src/StackflowReactPlugin.ts b/integrations/react/src/StackflowReactPlugin.ts
@@ -1,6 +1,6 @@
 import type { Activity, Stack, StackflowPlugin } from "@stackflow/core";
 
-export type StackflowReactPlugin<T = never> = () => {
+export type StackflowReactPlugin = () => {
   /**
    * Determine how to render by using the stack state
    */

diff --git a/integrations/react/src/stackflow.tsx b/integrations/react/src/stackflow.tsx
@@ -29,8 +29,8 @@ function parseActionOptions(options?: { animate?: boolean }) {
     return { skipActiveState: false };
   }
 
-  const isNullableAnimateOption =
-    options.animate === undefined || options.animate == null;
+  const isNullableAnimateOption = options.animate == null;
+
   if (isNullableAnimateOption) {
     return { skipActiveState: false };
   }
@@ -43,7 +43,7 @@ export type StackComponentType = React.FC<{
 }>;
 
 type StackflowPluginsEntry<T extends BaseActivities> =
-  | StackflowReactPlugin<T>
+  | StackflowReactPlugin
   | StackflowPluginsEntry<T>[];
 
 export type StackflowOptions<T extends BaseActivities> = {
@@ -120,7 +120,7 @@ export function stackflow<T extends BaseActivities>(
 ): StackflowOutput<T> {
   const plugins = (options.plugins ?? [])
     .flat(Infinity as 0)
-    .map((p) => p as StackflowReactPlugin<T>);
+    .map((p) => p as StackflowReactPlugin);
   const pluginInstances = plugins.map((plugin) => plugin());
 
   const activityComponentMap = Object.entries(options.activities).reduce(
@@ -285,7 +285,7 @@ export function stackflow<T extends BaseActivities>(
 
       [plugin]
         .flat(Infinity as 0)
-        .map((p) => p as StackflowReactPlugin<T>)
+        .map((p) => p as StackflowReactPlugin)
         .forEach((p) => {
           plugins.push(p);
           pluginInstances.push(p());

diff --git a/integrations/react/src/useActions.ts b/integrations/react/src/useActions.ts
@@ -11,8 +11,8 @@ function parseActionOptions(options?: { animate?: boolean }) {
     return { skipActiveState: false };
   }
 
-  const isNullableAnimateOption =
-    options.animate === undefined || options.animate == null;
+  const isNullableAnimateOption = options.animate == null;
+
   if (isNullableAnimateOption) {
     return { skipActiveState: false };
   }

diff --git a/integrations/react/src/utils/useMemoDeep.ts b/integrations/react/src/utils/useMemoDeep.ts
@@ -10,7 +10,7 @@ export function useMemoDeep<T>(next: T) {
     if (!isEqual) {
       previousRef.current = next;
     }
-  });
+  }, [next]);
 
   return isEqual ? previous : next;
 }