gh: fixup make targets

.github/workflows/exhaustive.yml

@@ -13,12 +13,23 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
+
     - uses: actions/checkout@v4
       with:
         fetch-depth: 1
+
     - name: Set up Go
       uses: actions/setup-go@v5
       with:
         go-version: '>=1.23.x'
+
+    - name: Test Core
+      run: make codecov
+
+    - name: Upload results to Codecov
+      uses: codecov/codecov-action@v4
+      with:
+        token: ${{ secrets.CODECOV_TOKEN }}
+
     - name: Test
-      run: make release --jobs=$(nproc)
+      rune: make testgenpkg testgenerate testbenchmarks testskipped calibrate vet

.github/workflows/macos.yml

@@ -19,4 +19,4 @@ jobs:
       with:
         go-version: '>=1.23.x'
     - name: Test
-      run: make ci exhaustive --jobs=$(nproc)
+      run: make release

.github/workflows/test.yml

@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        go-version: ['1.19', '1.20', '1.21.x', '1.22.x', '1.23.x']
+        go-version: ['1.19.x', '1.20.x', '1.21.x', '1.22.x', '1.23.x']
     steps:
       - uses: actions/checkout@v4
 

.gitignore

@@ -1,3 +1,4 @@
+coverage.txt
 *.out
 *.test
 /bin

Makefile

@@ -36,6 +36,12 @@ test testshort testverbose:
 exhaustive:
 	@GOGC=$(GO_GOGC) $(GO_TEST) $(EXHAUSTIVE_PKGS) -exhaustive
 
+# Generate code coverage report for strcase/bytecase
+.PHONY: codecov
+codecov: override GO_COVER_FLAGS =  -covermode=count
+codecov: override GO_COVER_FLAGS += -coverprofile=coverage.txt
+codecov: exhaustive
+
 # Assert that there are no skipped tests
 .PHONY: testskipped
 testskipped:
@@ -46,8 +52,6 @@ testskipped:
 		exit 1;                                                             \
 	fi
 
-# TODO: pass arguments to sub-make
-#
 # The gen package is separate from the strcase package (so we don't pollute
 # our go.mod with its dependencies) so we need to cd into its directory to
 # run the tests.
@@ -74,10 +78,8 @@ testall: exhaustive testskipped testgenerate testgenpkg
 # CI tests
 .PHONY: ci
 ci: test
-ci: testgenpkg
-ci: testgenerate
 ci: testbenchmarks
-ci: lint
+ci: vet
 
 # Calibrate brute-force cutover
 .PHONY: calibrate
@@ -145,7 +147,7 @@ pre-commit: .git/hooks/pre-commit
 
 # Run pre-release tests (excluding: golangci-lint)
 .PHONY: release
-release: test exhaustive testgenpkg testgenerate testbenchmarks calibrate
+release: exhaustive testgenpkg testgenerate testbenchmarks calibrate vet
 
 # Print information about the version of go being used
 .PHONY: env

internal/tables/assigned/assigned_test.go

@@ -23,7 +23,10 @@ func TestAssignedRunes(t *testing.T) {
 		}
 		return a
 	}
-	for _, version := range []string{"13.0.0", "15.0.0"} {
+	for _, version := range []string{
+		"13.0.0",
+		unicode.Version, // 15.0.0 unless testing with go1.19
+	} {
 		version := version
 		t.Run(version, func(t *testing.T) {
 			t.Parallel()

scripts/go-vet-harder

@@ -26,8 +26,12 @@ VETTOOLS=(
 DIR="$(mktemp -d -t 'go-vet-')"
 trap 'rm -r $DIR' EXIT
 
+touch "$DIR/vet"
+go vet ./... >"$DIR/vet" 2>&1 &
 
 for tool in "${VETTOOLS[@]}"; do
+    touch "$DIR/$tool"
+    "$tool" ./... >"$DIR/$tool" 2>&1 &
 done
 
 wait
@@ -41,10 +45,17 @@ fi
 VETTOOLS+=(vet)
 ERRORS=0
 for tool in "${VETTOOLS[@]}"; do
+    if [[ -s "$DIR/$tool" ]]; then
+        printf "%s: ${RED}error${RESET}\n" "$tool"
+        if [[ -n $REPLACE ]]; then
+            sed "s/$REPLACE//g" "$DIR/$tool" | pr -o4 -t -
         else
+            pr -o4 -t - "$DIR/$tool"
         fi
         ERRORS=1
     else
+        printf "%s: ${GREEN}pass${RESET}\n" "$tool"
     fi
 done
 
+exit $ERRORS

scripts/test-benchmarks.bash

@@ -14,6 +14,12 @@ fi
 
 echo '# Testing benchmarks'
 
+if ! command -v readarray &>/dev/null; then
+    printf '%sSKIP%s\t%s\n' "${RED}" "${RESET}" \
+        "readarray not supported by this verison of bash"
+    exit 0
+fi
+
 # Go packages
 readarray -t PACKAGES < <(go list ./...)
 if ((${#PACKAGES[@]} == 0)); then