Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more events 2 #104

Merged
merged 10 commits into from
Jul 29, 2023
Merged

Fix more events 2 #104

merged 10 commits into from
Jul 29, 2023

Conversation

bruceharrison1984
Copy link
Owner

This should fix a couple issues.

  • The more events indicator should functional properly again
    • A small bug where it would never clear old events has been fixed
  • The input events array is now de-structured within the component. This should fix any errors people had with dynamic event arrays not updating the calendar.
    • This was an insidious bug because it's not immediately apparent you would need to destructure your event arrays, so we'll do it for you.

@github-actions
Copy link

github-actions bot commented Jul 28, 2023

Coverage Report for ./packages/Schedulely

Status Category Percentage Covered / Total
🔵 Lines 87.19% 1355 / 1554
🔵 Statements 87.19% 1355 / 1554
🔵 Functions 86.04% 37 / 43
🔵 Branches 95.48% 127 / 133
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
packages/Schedulely/src/components/defaultDay/DefaultDay.tsx 100% 100% 100% 100%
packages/Schedulely/src/hooks/useEventIntersection.tsx 81.81% 50% 100% 81.81% 10-11
packages/Schedulely/src/layouts/eventWeekLayout/EventWeekLayout.tsx 100% 95.45% 80% 100%
packages/Schedulely/src/layouts/monthLayout/MonthLayout.tsx 100% 100% 100% 100%
packages/Schedulely/src/providers/CalendarProvider.tsx 86.28% 100% 100% 86.28% 81-90, 94-103, 123, 127-129
packages/Schedulely/src/providers/EventIntersectionProvider.tsx 21.13% 100% 0% 21.13% 27-123
packages/Schedulely/src/types/EventPriority.ts 100% 100% 100% 100%
packages/Schedulely/src/types/InternalEventWeek.ts 100% 100% 100% 100%
packages/Schedulely/src/types/SchedulelyProps.ts 100% 100% 100% 100%
packages/Schedulely/src/types/state/CalendarContextState.ts 100% 100% 100% 100%
Generated in workflow #55

@bruceharrison1984 bruceharrison1984 merged commit 0b4bb2a into main Jul 29, 2023
3 checks passed
@bruceharrison1984 bruceharrison1984 deleted the fix-more-events-2 branch July 29, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Overflow indicator always appears Order event display based on length
1 participant