Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Overflow indicator always appears #103

Closed
bruceharrison1984 opened this issue Jul 28, 2023 · 1 comment · Fixed by #104
Closed

Regression: Overflow indicator always appears #103

bruceharrison1984 opened this issue Jul 28, 2023 · 1 comment · Fixed by #104
Labels
regression Something used to work, now it doesn't

Comments

@bruceharrison1984
Copy link
Owner

Describe the bug
Any day that has an event always displays the overflow indicator.

Expected behavior
Overflow indicator should only appear when events are hidden

Screenshots
image

Likely resulted from changes during this PR: #97
@bruceharrison1984 bruceharrison1984 added bug Something isn't working regression Something used to work, now it doesn't and removed bug Something isn't working labels Jul 28, 2023
@bruceharrison1984
Copy link
Owner Author

bruceharrison1984 commented Jul 28, 2023 •
edited
Loading

Further investigation show that we are no longer setting the visible property on the internal calendar events, so even though all events are visible, the calendar thinks they are not visible.

This likely means reverting some of #97 and attempting to fix both issues at once.

@bruceharrison1984 bruceharrison1984 linked a pull request Jul 28, 2023 that will close this issue
Fix more events 2 #104
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression Something used to work, now it doesn't
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix more events 2 bruceharrison1984/Schedulely
1 participant
@bruceharrison1984