Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calls this.settings in settings handling #901

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

KazuCocoa
Copy link
Member

As same as UIA2, maybe should this driver also call this.settings stuff to call plugins?
Fixes #900

Copy link
Member

@jlipps jlipps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, good idea.

@KazuCocoa KazuCocoa merged commit 7858760 into master Aug 17, 2023
16 checks passed
@KazuCocoa KazuCocoa deleted the fix-settings branch August 17, 2023 08:11
github-actions bot pushed a commit that referenced this pull request Aug 17, 2023
## [2.25.2](v2.25.1...v2.25.2) (2023-08-17)

### Bug Fixes

* calls this.settings in settings handling ([#901](#901)) ([7858760](7858760))
@github-actions
Copy link

🎉 This PR is included in version 2.25.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Espresso] Could not find matching setting. Known setting names are: [driver]
2 participants