fix: calls this.settings in settings handling (#901)

appium · Aug 17, 2023 · 7858760 · 7858760
1 parent ee2d693
commit 7858760
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/lib/commands/general.js b/lib/commands/general.js
@@ -322,11 +322,14 @@ commands.mobileClickAction = async function mobileClickAction (opts = {}) {
 };
 
 commands.updateSettings = async function updateSettings (settings) {
-  return await this.espresso.jwproxy.command(`/appium/settings`, 'POST', { settings });
+  await this.settings.update(settings);
+  await this.espresso.jwproxy.command(`/appium/settings`, 'POST', { settings });
 };
 
 commands.getSettings = async function getSettings () {
-  return await this.espresso.jwproxy.command(`/appium/settings`, 'GET');
+  const driverSettings = this.settings.getSettings();
+  const serverSettings = await this.espresso.jwproxy.command(`/appium/settings`, 'GET');
+  return {...driverSettings, ...serverSettings};
 };
 
 // Stop proxying to any Chromedriver and redirect to Espresso