Upgrade dependencies

[vttranlina]

No description provided.

[vttranlina]

io.cucumber look very outdated, (from 2018)
the compile failed when I tried to update 2.4.0 -> 7.13.0, I'm not in it, so I keep 2.4.0
Maybe we should have a plan to update it or maybe drop it? (it only use in test classes)

[chibenwa]

org.apache.james.webadmin.routes.VacationRoutesTest.postVacationUpdatesAll

Minor date formating changes

expected: Optional[2021-09-20T10:00Z[UTC]]
 but was: Optional[2021-09-20T10:00Z]

Is there a way to configure jackson to keep the timezone?

org.apache.james.backends.opensearch.OpenSearchIndexerTest.updateMessages

org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a lambda expression in org.apache.james.backends.opensearch.OpenSearchIndexerTest 
expected: 1L
 but was: 0L within 10 seconds.
	at org.apache.james.backends.opensearch.OpenSearchIndexerTest.awaitForOpenSearch(OpenSearchIndexerTest.java:252)
	at org.apache.james.backends.opensearch.OpenSearchIndexerTest.updateMessages(OpenSearchIndexerTest.java:109)
Caused by: org.opentest4j.AssertionFailedError: 

expected: 1L
 but was: 0L
	at org.apache.james.backends.opensearch.OpenSearchIndexerTest.lambda$awaitForOpenSearch$9(OpenSearchIndexerTest.java:257)

Related?

org.apache.james.jmap.draft.crypto.SecurityKeyLoaderTest.loadShouldReturnAsymmetricKeysWhenRawPublicKey

The provided [org.bouncycastle.asn1.x509.SubjectPublicKeyInfo] pem type is not (yet) supported

Some bouncy castle magic required here.

[vttranlina]

org.apache.james.backends.opensearch.OpenSearchIndexerTest.updateMessages

IMO we should keep opensearch-java 2.1.0 for easier, I don't know why 2.6.0 throw

[chibenwa]

Can you share the error?

[vttranlina]

Can you share the error?

sorry it did not throw, the query at org.apache.james.backends.opensearch.OpenSearchIndexerTest#updateMessages line 109 does not return totalHit = 1 (it returns 0)

[chibenwa]

Ok create a separate ticket to upgrade OpenSearch please...

[Arsnael]

OpenSearch you might want to upgrade the docker container as well, maybe the API slightly changed?

I agree to open a ticket just for this though. I just checked on Opensearch doc : https://opensearch.org/docs/latest/clients/java/

It seems the latest java client update has an integrated transport class. We need to measure the impact of refactoring that would allow us to drop the rest client library. If it's not too bad, then we need perf tests as well to see if there is a gain or not. If the result is good enough, we could switch and drop the opensearch-rest-client dependency.

WDYT?

[chibenwa]

Agree.

Ticket please.

[Arsnael]

A;right give me a minute to create it :)

[vttranlina]

org.apache.james.webadmin.routes.VacationRoutesTest.postVacationUpdatesAll

Minor date formating changes

expected: Optional[2021-09-20T10:00Z[UTC]]
 but was: Optional[2021-09-20T10:00Z]

Is there a way to configure jackson to keep the timezone?

It looks like the new result after the update is better
This was intended since 2.15 FasterXML/jackson-modules-java8#267

I think we should modify test cases for that (don't change the configuration ObjectMapper)

[chibenwa]

Ok yes there is still the Z which means zone offset. Of for the.

[vttranlina]

Ci error

 Not same digest as expected: expected <16073f10204751cd71d3b4ea93be2649> was <d41d8cd98f00b204e9800998ecf8427e> -> [Help 1]

I don't know why it does not match,
my md5 is 16073f10204751cd71d3b4ea93be2649

[chibenwa]

The digest is not stable, I encountered that as well.

-> Open a ticket upstream on glowroot github?
-> We might temporarilly drop glowroot, like we did on 3.7.x

[vttranlina]

The digest is not stable, I encountered that as well.

it looks like from download-maven-plugin when upgrade 1.6.8 -> 1.7.0, I reverted it and now waiting to check new ci state

Weird, yesterday, I tested with a desktop PC and it work. And now ci and other pc error

[vttranlina]

Squash fixup & rebase master & add new commits

[vttranlina]

Ci Issue?

com.github.dockerjava.api.exception.NotFoundException: Status 404: {"message":"No such image: rabbitmq:3.12.1-management"}

The image is already available:: https://hub.docker.com/layers/library/rabbitmq/3.12.1-management/images/sha256-b4d3bf93ceaa261b748c03aab80f4c616962e3aa81eb40fd41824077aad9418f?context=explore

[Arsnael]

Hm indeed... Maybe something wrong with the VM docker or connection issue when trying to fetch the image?Let me restart your build and we will see

[Arsnael]

If there is still issues with this PR and you can't seem to get a green build, I would suggest to potentially break down this PR in smaller ones to make it easier to merge (as this is becoming a bit of a monster), like for example:

• lib updates
• maven plugins updates
• docker image updates
• etc

[quantranhong1999]

rebase needed

[Arsnael]

I'm closing this, as this PR has been cut into smaller steps and some of those have been merged already.