Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency updates #4813

Closed
chibenwa opened this issue Jul 10, 2023 · 6 comments
Closed

Dependency updates #4813

chibenwa opened this issue Jul 10, 2023 · 6 comments
Assignees

Comments

@chibenwa
Copy link
Member

Update all relevant James dependencies, docker images, etc...

@vttranlina vttranlina self-assigned this Jul 14, 2023
@vttranlina
Copy link
Member

apache#1647

@vttranlina
Copy link
Member

Upgrade dependencies - only lib apache#1655

The quick performance test result:

JMAP

1pod, 5k user, charge1 -> sandbox

Before

image

After

image

IMAP

1pod, 6k user, charge1 -> sandbox

Before

image

After

image

Conclusion

Both IMAP & JMAP decrease performance after updating libraries

//Maybe we should re-test more times for sure?

@quantranhong1999
Copy link
Member

If Benoit is here, I guess he would be interested in Flamegraph.

BTW is there any other suspect change/commit between "before" and "after" besides the libs upgrade?

@vttranlina
Copy link
Member

:( one more time I forgot to dump the flame graph

@vttranlina
Copy link
Member

BTW is there any other suspect change/commit between "before" and "after" besides the libs upgrade?

yes

before: james-commit: 76ac783
After: james-commit: bb49990

@Arsnael
Copy link
Member

Arsnael commented Jul 31, 2023

JMAP looks ok I think, negligeable, could be related to the platform and OVH.

IMAP looks suspicious but I would redeploy fresh pods and retest to make sure.

Also when testing, do you do a small preflight perf test before the real one or not? James is like a diesel, need to run it a bit first until it gets warmer, then it can handle better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants