Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hints #19

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions src/ficamp/__main__.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import argparse
from collections import defaultdict
from decimal import Decimal

import questionary
from dotenv import load_dotenv
from sqlmodel import Session, SQLModel, create_engine, select

from ficamp.classifier.infer import infer_tx_category
from ficamp.classifier.keywords import sort_by_keyword_matches
from ficamp.classifier.preprocessing import preprocess
from ficamp.datastructures import Tx
Expand Down Expand Up @@ -38,6 +40,15 @@ def cli() -> argparse.Namespace:
"categorize", help="Categorize transactions"
)
categorize_parser.set_defaults(func=categorize)
categorize_parser.add_argument(
"--hints",
help="Query some APIs to hint the categroy of the Tx",
action="store_true",
)

# Subparser for the sync command
categorize_parser = subparsers.add_parser("sync", help="Report transactions")
categorize_parser.set_defaults(func=sync)

args = parser.parse_args()

Expand Down Expand Up @@ -116,7 +127,7 @@ def query_business_category(tx, session):
return answer


def categorize(engine):
def categorize(args, engine):
"""Classify transactions into categories"""
try:
with Session(engine) as session:
Expand All @@ -125,6 +136,9 @@ def categorize(engine):
print(f"Got {len(results)} Tx to categorize")
for tx in results:
print(f"Processing {tx}")
hinted_category = infer_tx_category(tx)
Copy link
Collaborator

@fabridamicelli fabridamicelli Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should only happen if user opts in to --hints.
Otherwise this breaks usage without a google API key.
In other words: we are missing an if-statement or something like that

if hinted_category:
print(f"Hint! This seems to be category: {hinted_category}")
tx_category = query_business_category(tx, session)
if tx_category:
print(f"Saving category for {tx.concept}: {tx_category}")
Expand All @@ -138,13 +152,25 @@ def categorize(engine):
print("Session interrupted. Closing.")


def sync(args, engine):
total_per_category = defaultdict(Decimal)
with Session(engine) as session:
statement = select(Tx)
results = session.exec(statement).all()
print(f"Got {len(results)} Tx to report")
for tx in results:
total_per_category[tx.category] += tx.amount
for k, v in total_per_category.items():
print(k, v)


def main():
engine = create_engine("sqlite:///ficamp.db") # create DB
SQLModel.metadata.create_all(engine) # create tables
try:
args = cli()
if args.command:
args.func(engine)
args.func(args, engine)
except KeyboardInterrupt:
print("\nClosing")

Expand Down
2 changes: 0 additions & 2 deletions src/ficamp/classifier/infer.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,4 @@ def infer_tx_category(tx):
"""Will try to guess the category using different actions."""
print(f"Raw is: {tx.concept}\n")
gmap_category = query_gmaps_category(tx.concept_clean)
if gmap_category:
print(f"Google Maps category is {gmap_category}")
return gmap_category
Loading