Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hints #19

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Hints #19

wants to merge 3 commits into from

Conversation

gilgamezh
Copy link
Contributor

print hints from Gmap to help the user

@gilgamezh
Copy link
Contributor Author

should merge #18 first

@@ -125,6 +136,9 @@ def categorize(engine):
print(f"Got {len(results)} Tx to categorize")
for tx in results:
print(f"Processing {tx}")
hinted_category = infer_tx_category(tx)
Copy link
Collaborator

@fabridamicelli fabridamicelli Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should only happen if user opts in to --hints.
Otherwise this breaks usage without a google API key.
In other words: we are missing an if-statement or something like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants