Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable extending conda deps in new implementation #1567

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

saikonen
Copy link
Collaborator

@saikonen saikonen commented Oct 4, 2023

re-enables the support for extending conda dependencies via overriding get_pinned_conda_libs in extensions.

Addresses pending review comment from @romain-intel

Base automatically changed from pip-decorator to master October 4, 2023 14:38
@saikonen saikonen force-pushed the chore/enable-extending-conda-deps branch from c4c3c40 to fcb7032 Compare October 4, 2023 18:25
Copy link
Contributor

@romain-intel romain-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@savingoyal savingoyal merged commit f52d03d into master Oct 9, 2023
20 checks passed
@savingoyal savingoyal deleted the chore/enable-extending-conda-deps branch October 9, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants