Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix two possible issues with the environment escape communication #1555

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix two possible issues with the environment escape communication #1555

merged 1 commit into from
Sep 27, 2023

Commits on Sep 27, 2023

  1. Fix two possible issues with the environment escape communication 

    The first issue is when subprocesses are created after the main process has
activated the environment escape. In this case, multiple processes could try
to communicate wit the single escaped server which is a big no no. We explicitly
block this from happening now. The case we ran into was an object allocated in a parent
being gc in a subprocess.

The second issue relates to the GC which could trigger *while* another communication
was happening. This could result in a deadlock since the lock protecting the communication
is not reentrant (on purpose). We solve this by preventing the GC from being active during
that time.
    @romain-intel
    romain-intel committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    cfcb44d View commit details
    Browse the repository at this point in the history