Fix two possible issues with the environment escape communication #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first issue is when subprocesses are created after the main process has activated the environment escape. In this case, multiple processes could try to communicate wit the single escaped server which is a big no no. We explicitly block this from happening now. The case we ran into was an object allocated in a parent being gc in a subprocess. The second issue relates to the GC which could trigger *while* another communication was happening. This could result in a deadlock since the lock protecting the communication is not reentrant (on purpose). We solve this by preventing the GC from being active during that time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first issue is when subprocesses are created after the main process has activated the environment escape. In this case, multiple processes could try to communicate wit the single escaped server which is a big no no. We explicitly block this from happening now. The case we ran into was an object allocated in a parent being gc in a subprocess.
The second issue relates to the GC which could trigger while another communication was happening. This could result in a deadlock since the lock protecting the communication is not reentrant (on purpose). We solve this by preventing the GC from being active during that time.