Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong pointer usage & Fix tests not using SYSCONFDIR #1245

Merged
merged 4 commits into from
Jul 18, 2023
Merged

Fix wrong pointer usage & Fix tests not using SYSCONFDIR #1245

merged 4 commits into from
Jul 18, 2023

Commits on Jul 18, 2023

  1. Fix duplicate layer test which used /etc 

    The ImplicitLayers.DuplicateLayers test requires there to be two separate
files on the file system, located in different paths. To accomplish that, the
test writes a file to /etc and another to the default location. By default,
that is typically /usr/local/share. If the project is configured to set /etc
as that default location, only one file will be written.

The fix is to move the duplicate file from /etc to the default home directory,
since that is configured from inside the tests itself. This does change the
order the layers are found in, so the logic of the test had to be flipped.
    @charles-lunarg
    charles-lunarg committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    cc5c59c View commit details
    Browse the repository at this point in the history

  2. Fix wrong pointer usage 

    get_override_layer_override_paths logs the path used, but during the refactor it
failed to dereference the double pointer properly, leading to the loader_log
message reading garbage. This was not caught on x64 address sanitizer builds, but
was on the 32 bit build.
    @charles-lunarg
    charles-lunarg committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    581545a View commit details
    Browse the repository at this point in the history

  3. Add test for override layer path logging

    @charles-lunarg
    charles-lunarg committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    920e934 View commit details
    Browse the repository at this point in the history

  4. Set SYSCONFDIR in linux-32 actions CI run 

    Ensures that this build setting is exercised.
    @charles-lunarg
    charles-lunarg committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    8066785 View commit details
    Browse the repository at this point in the history