Fix wrong pointer usage & Fix tests not using SYSCONFDIR #1245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI Vulkan-Loader build queued with queue ID 595. |
|
CI Vulkan-Loader build # 2066 running. |
|
CI Vulkan-Loader build # 2066 failed. |
charles-lunarg
force-pushed
the
fix_pointer_usage
branch
from
ad5ba8a
to
839e3af
Compare
|
CI Vulkan-Loader build queued with queue ID 8639. |
|
CI Vulkan-Loader build # 2071 running. |
|
CI Vulkan-Loader build # 2071 failed. |
The ImplicitLayers.DuplicateLayers test requires there to be two separate files on the file system, located in different paths. To accomplish that, the test writes a file to /etc and another to the default location. By default, that is typically /usr/local/share. If the project is configured to set /etc as that default location, only one file will be written. The fix is to move the duplicate file from /etc to the default home directory, since that is configured from inside the tests itself. This does change the order the layers are found in, so the logic of the test had to be flipped.
get_override_layer_override_paths logs the path used, but during the refactor it failed to dereference the double pointer properly, leading to the loader_log message reading garbage. This was not caught on x64 address sanitizer builds, but was on the 32 bit build.
Ensures that this build setting is exercised.
charles-lunarg
force-pushed
the
fix_pointer_usage
branch
from
839e3af
to
8066785
Compare
|
CI Vulkan-Loader build queued with queue ID 8693. |
|
CI Vulkan-Loader build # 2072 running. |
|
CI Vulkan-Loader build # 2072 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_override_layer_override_paths logs the path used, but during the refactor it
failed to dereference the double pointer properly, leading to the loader_log
message reading garbage. This was not caught on x64 address sanitizer builds, but
was on the 32 bit build.