Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EVOware pipetting commands #21

Merged
merged 54 commits into from
Jan 25, 2023
Merged

Conversation

Y0dler
Copy link
Contributor

@Y0dler Y0dler commented Jan 16, 2023

This PR aims to implement pipetting commands (as they can be used in the user interface of the EvoWARE) within worklists, i.e. as advanced worklist commands. This enables some pipetting schemes which are not possible with other worklist commands because it allows more precise control over pipetting and wash steps without interference from any grouping shenanigans.

@Y0dler Y0dler self-assigned this Jan 17, 2023
@Y0dler Y0dler added the enhancement New feature or request label Jan 17, 2023
Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very much looking forward to this!

I noticed two changes that are not strictly related to the addition of EVO commands:

  • Typo correction in the ValueError messages
  • Enforcing latin-1 encoding

I think it would be best to do these changes in a separate PR which we can fast-track & merge.

Please add a few basic test cases for the new features. You can run them with pytest -v --cov=robotools --cov-report term-missing robotools/tests.py to get a report on the line coverage. With the -k SomePartOfTheTestCaseName you can filter to run tests matching some pattern which is useful too.

I'm keeping my mouth shut over general refactoring changes that I have in mind. But I'll open new issues about them.

robotools/evotools/__init__.py Outdated Show resolved Hide resolved
robotools/evotools/__init__.py Outdated Show resolved Hide resolved
robotools/evotools/__init__.py Outdated Show resolved Hide resolved
robotools/evotools/__init__.py Outdated Show resolved Hide resolved
robotools/evotools/__init__.py Outdated Show resolved Hide resolved
robotools/evotools/__init__.py Outdated Show resolved Hide resolved
robotools/evotools/__init__.py Outdated Show resolved Hide resolved
robotools/evotools/__init__.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023

Codecov Report

Merging #21 (dc73d95) into master (9cb5920) will decrease coverage by 18.32%.
The diff coverage is 27.93%.

@@             Coverage Diff             @@
##           master      #21       +/-   ##
===========================================
- Coverage   97.20%   78.89%   -18.32%     
===========================================
  Files           5        5               
  Lines         715      938      +223     
===========================================
+ Hits          695      740       +45     
- Misses         20      198      +178     
Impacted Files Coverage Δ
robotools/evotools/__init__.py 65.47% <27.93%> (-32.90%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

robotools/tests.py Outdated Show resolved Hide resolved
@Y0dler Y0dler force-pushed the add-evoware-pipetting-commands branch from b3cb493 to dc73d95 Compare January 18, 2023 15:26
robotools/evotools/__init__.py Outdated Show resolved Hide resolved
robotools/evotools/__init__.py Outdated Show resolved Hide resolved
robotools/evotools/__init__.py Outdated Show resolved Hide resolved
robotools/evotools/__init__.py Outdated Show resolved Hide resolved
robotools/evotools/__init__.py Outdated Show resolved Hide resolved
robotools/tests.py Outdated Show resolved Hide resolved
robotools/tests.py Show resolved Hide resolved
robotools/tests.py Outdated Show resolved Hide resolved
robotools/tests.py Outdated Show resolved Hide resolved
robotools/tests.py Outdated Show resolved Hide resolved
@Y0dler Y0dler force-pushed the add-evoware-pipetting-commands branch from 656b7b1 to 91cfd04 Compare January 25, 2023 10:26
Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let#s take care of remaining ToDos in follow-up PRs.

@michaelosthege michaelosthege merged commit 9feda76 into master Jan 25, 2023
@michaelosthege michaelosthege deleted the add-evoware-pipetting-commands branch January 25, 2023 11:49
@michaelosthege michaelosthege changed the title Add evoware pipetting commands Add EVOware pipetting commands Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants