Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor internal functions to use dicts or namedtuples instead of long lists of args #25

Open
michaelosthege opened this issue Jan 23, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@michaelosthege
Copy link
Member

Some internal functions take a vera long list of args as inputs, only to return another long list of args.
This makes the code really hard to read.

We should refactor these to use dicts or namedtuples.

Candidates:

  • def _prepare_aspirate_dispense_parameters(
    rack_label: str,
    position: int,
    volume: float,
    liquid_class: str = "",
    tip: typing.Union[Tip, int, collections.abc.Iterable] = Tip.Any,
    rack_id: str = "",
    tube_id: str = "",
    rack_type: str = "",
    forced_rack_type: str = "",
    max_volume: typing.Optional[int] = None,
    ) -> typing.Tuple[str, int, float, str, typing.Union[Tip, int, collections.abc.Iterable], str, str, str, str]:
  • _prepare_evo_wash_parameters from Add EVOware pipetting commands #21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant