-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the az.create-aks
task
#967
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -60,12 +60,12 @@ func TestInvokes(t *testing.T) { | |
testAwsInvokeVM(t, tmpConfigFile, *workingDir) | ||
}) | ||
|
||
t.Run("invoke-docker-vm", func(t *testing.T) { | ||
t.Run("aws.invoke-docker-vm", func(t *testing.T) { | ||
t.Parallel() | ||
testInvokeDockerVM(t, tmpConfigFile, *workingDir) | ||
}) | ||
|
||
t.Run("invoke-kind", func(t *testing.T) { | ||
t.Run("aws.invoke-kind", func(t *testing.T) { | ||
t.Parallel() | ||
testInvokeKind(t, tmpConfigFile, *workingDir) | ||
}) | ||
|
@@ -76,7 +76,7 @@ func testAzureInvokeVM(t *testing.T, tmpConfigFile string, workingDirectory stri | |
|
||
stackName := fmt.Sprintf("az-invoke-vm-%s", os.Getenv("CI_PIPELINE_ID")) | ||
t.Log("creating vm") | ||
createCmd := exec.Command("invoke", "az.create-vm", "--no-interactive", "--stack-name", stackName, "--config-path", tmpConfigFile, "--account", "agent-qa") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❓ question There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I moved it to the config file: https://github.com/DataDog/test-infra-definitions/pull/967/files#diff-5b0d7f0d4cd5bb98edb0f1e6b5ac0747cae4be958137b00d9785e4863a90acdcR12 sorry it was not super explicit. We already do the same thing with AWS so I just centralised everything |
||
createCmd := exec.Command("invoke", "az.create-vm", "--no-interactive", "--stack-name", stackName, "--config-path", tmpConfigFile) | ||
createCmd.Dir = workingDirectory | ||
createOutput, err := createCmd.Output() | ||
assert.NoError(t, err, "Error found creating vm: %s", string(createOutput)) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 praise