Update the az.create-aks task
#967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorentClarret
changed the title
az.create-aks task and add it to the tests
FlorentClarret
force-pushed
the
florentclarret/create-aks
branch
8 times, most recently
from
abf9482
to
bb1cdcc
Compare
pducolin
reviewed
Jul 26, 2024
integration-tests/invoke_test.go
Outdated
| @@ -55,17 +55,22 @@ func TestInvokes(t *testing.T) { | |||
| testAzureInvokeVM(t, tmpConfigFile, *workingDir) | |||
| }) | |||
|
|
|||
| t.Run("az.create-aks", func(t *testing.T) { | |||
There was a problem hiding this comment.
🔨 warning
We have limited aks resources and it takes usually very long to create an aks cluster, similarly to eks. I would rather have it as a manual test
FlorentClarret
force-pushed
the
florentclarret/create-aks
branch
from
bb1cdcc
to
ae94e61
Compare
FlorentClarret
changed the title
az.create-aks task and add it to the testsaz.create-aks task
pducolin
approved these changes
Jul 26, 2024
| ``` | ||
|
|
||
| ## Quick start: Create an EKS (Linux/Windows) + Fargate (Linux) Cluster + Agent (Helm) | ||
|
|
||
| ``` | ||
| # You need to have a DD APIKey AND APPKey in variable DD_API_KEY / DD_APP_KEY | ||
| aws-vault exec sso-agent-sandbox-account-admin -- pulumi up -c scenario=aws/eks -c ddinfra:aws/defaultKeyPairName=<your_exisiting_aws_keypair_name> -c ddinfra:env=aws/agent-sandbox -c ddagent:apiKey=$DD_API_KEY -c ddagent:appKey=$DD_APP_KEY -s <your_name>-eks | ||
| pulumi up -c scenario=aws/eks -c ddinfra:aws/defaultKeyPairName=<your_exisiting_aws_keypair_name> -c ddinfra:env=aws/agent-sandbox -c ddagent:apiKey=$DD_API_KEY -c ddagent:appKey=$DD_APP_KEY -s <your_name>-eks |
| @@ -76,7 +76,7 @@ func testAzureInvokeVM(t *testing.T, tmpConfigFile string, workingDirectory stri | |||
|
|
|||
| stackName := fmt.Sprintf("az-invoke-vm-%s", os.Getenv("CI_PIPELINE_ID")) | |||
| t.Log("creating vm") | |||
| createCmd := exec.Command("invoke", "az.create-vm", "--no-interactive", "--stack-name", stackName, "--config-path", tmpConfigFile, "--account", "agent-qa") | |||
There was a problem hiding this comment.
❓ question
It doesn't work with agent-qa? Or we are setting it at setup?
There was a problem hiding this comment.
I moved it to the config file: https://github.com/DataDog/test-infra-definitions/pull/967/files#diff-5b0d7f0d4cd5bb98edb0f1e6b5ac0747cae4be958137b00d9785e4863a90acdcR12 sorry it was not super explicit. We already do the same thing with AWS so I just centralised everything
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
az.create-aksto create clusters in agent sandbox/qaaz.create-aksto the integration tests in this CI, it takes only around 8 minutes but we do not have a lot of resources on AzureSome semi-related tasks to:
aws-vault execcommands, not needed anymore since Set the Profile in the AwsProvider to avoid wrapping the commands intoaws-vaultcommands #917Which scenarios this will impact?
Motivation
Allow users to create AKS in our new sandbox
Additional Notes
ssh-ed25519keys here. They do not work with AKS and we explicitly needssh-rsakeys so I created a new pair and pushed it