Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isochrone dev #35

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Isochrone dev #35

wants to merge 35 commits into from

Commits on Aug 22, 2023

  1. not sure at this point how to organize everything but just for the sa… 

    …ke of getting started...
    @AlexaVillaume
    AlexaVillaume committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    bdcd3b5 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. fixing a small issue with getting data_path

    @AlexaVillaume
    AlexaVillaume committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    af1f5b1 View commit details
    Browse the repository at this point in the history

  2. fixing a small issue with getting data_path

    @AlexaVillaume
    AlexaVillaume committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    b470e88 View commit details
    Browse the repository at this point in the history

  3. renaming to be more informative

    @AlexaVillaume
    AlexaVillaume committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    9a44b80 View commit details
    Browse the repository at this point in the history

  4. whoops...this is why the renaming necessary

    @AlexaVillaume
    AlexaVillaume committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    42216fa View commit details
    Browse the repository at this point in the history

  5. need some safeguards wrt coverage between the isochrones and the stel… 

    …lar libaries
    @AlexaVillaume
    AlexaVillaume committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    adb101a View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. making progress on getting MLCRs, including fixing SSP synthesis

    @AlexaVillaume
    AlexaVillaume committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a7f889b View commit details
    Browse the repository at this point in the history

  2. adding salpeter imf to help troubleshoot and to help figure out where… 

    … the imf weight and normalization functions should go for the purposes of getting m2l
    @AlexaVillaume
    AlexaVillaume committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c264505 View commit details
    Browse the repository at this point in the history

  3. getting salpeter imf working

    @AlexaVillaume
    AlexaVillaume committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    70fd5db View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. adding to the normalization functionality in the abstract IMF class

    @AlexaVillaume
    AlexaVillaume committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    47f52ad View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2023

  1. adding unit test for imf normalization

    @AlexaVillaume
    AlexaVillaume committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    f3d4d8d View commit details
    Browse the repository at this point in the history

  2. the wonders of unit tests

    @AlexaVillaume
    AlexaVillaume committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    36355a8 View commit details
    Browse the repository at this point in the history

  3. added class for abritary two slope powerlawe IMF

    @AlexaVillaume
    AlexaVillaume committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    f15e04d View commit details
    Browse the repository at this point in the history

  4. mostly just refactoring the forward function to make it easier for me… 

    … to debug
    @AlexaVillaume
    AlexaVillaume committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    69880e3 View commit details
    Browse the repository at this point in the history

  5. small changes

    @AlexaVillaume
    AlexaVillaume committed Sep 14, 2023
    Configuration menu
    Copy the full SHA
    5e3adba View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. leaving this to fix mist isochrone issue

    @AlexaVillaume
    AlexaVillaume committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    522c0ef View commit details
    Browse the repository at this point in the history

  2. Wondering if the error I'm getting with some of the isochrones, e.g.,… 

    … S.isochrone_grid.metallicities == -0.50, is the same problem Connor is seeing when running the test_isochrone unit test
    @AlexaVillaume
    AlexaVillaume committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    01ad142 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. should not be making selections based on anything other than age at t… 

    …he point of getting the grid constructed
    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    37de906 View commit details
    Browse the repository at this point in the history

  2. Now that I have a clearer understanding of nature of the problem -- s… 

    …omething is wrong with how we're constructing the isochrone andor selecting a given isochrone from the grid -- I am creating a new notebook to dig into this issue specificially
    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    ea875dd View commit details
    Browse the repository at this point in the history

  3. at the very least the selection by metalliicity is wrong in get_isoch… 

    …rone ><
    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    9ec205f View commit details
    Browse the repository at this point in the history

  4. close but no cigar selecting on both metallicity AS WELL AS age...but… 

    … progress
    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    9726b68 View commit details
    Browse the repository at this point in the history

  5. the issues with the determining the metallicity and age indices does … 

    …not preclude some other problem in the creation of the grid itself. See how nothing comes back for age 10.1, 10.2, 10.3
    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    5773c3d View commit details
    Browse the repository at this point in the history

  6. There is indeed a serious bug in the construction of the isochrone gr… 

    …ide in get_isochrones.py
    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    785e37a View commit details
    Browse the repository at this point in the history

  7. making progress fixing the bugs, something still not right about the … 

    …age indexing
    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    5e43c31 View commit details
    Browse the repository at this point in the history

  8. several bug fixes involving indexing, data typing, and some float iss… 

    …ues all in regards to fixing the isochrone selection
    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    0afb706 View commit details
    Browse the repository at this point in the history

  9. checking full ssp synthesis in light of the bug fixes I made to the i… 

    …sochrone grid and isochrone selection...hopefully now I will have an easier time debugging the this now that the isochrones should at least be correct
    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    dbf0ecd View commit details
    Browse the repository at this point in the history

  10. introducing the use of a lighthouse environment variable in the hopes… 

    … that it will make establishing paths less of of a headache
    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    76367f2 View commit details
    Browse the repository at this point in the history

  11. trying to find all instances where environment variable should be used

    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    425825b View commit details
    Browse the repository at this point in the history

  12. trying to find all instances where environment variable should be used

    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    ed73aa9 View commit details
    Browse the repository at this point in the history

  13. added unit test for enviornment variable

    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    fbc3104 View commit details
    Browse the repository at this point in the history

  14. using environment variable

    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    a3ae6f0 View commit details
    Browse the repository at this point in the history

  15. misplaced forward slash

    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    f87806b View commit details
    Browse the repository at this point in the history

  16. think this is the last of directory_path variales that need to be rep… 

    …laced
    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    36e0990 View commit details
    Browse the repository at this point in the history

  17. fixed all the path stuff st I can delete the notebooks from this repo… 

    … and run them from light-house-analyses
    @AlexaVillaume
    AlexaVillaume committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    c7506d1 View commit details
    Browse the repository at this point in the history

  18. Merge branch 'main' into isochrone_dev

    @AlexaVillaume
    AlexaVillaume authored Nov 22, 2023
    Configuration menu
    Copy the full SHA
    308d6e7 View commit details
    Browse the repository at this point in the history