Isochrone dev #35
Open
Isochrone dev #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke of getting started...
… the imf weight and normalization functions should go for the purposes of getting m2l
… S.isochrone_grid.metallicities == -0.50, is the same problem Connor is seeing when running the test_isochrone unit test
…he point of getting the grid constructed
…omething is wrong with how we're constructing the isochrone andor selecting a given isochrone from the grid -- I am creating a new notebook to dig into this issue specificially
…not preclude some other problem in the creation of the grid itself. See how nothing comes back for age 10.1, 10.2, 10.3
…ide in get_isochrones.py
…ues all in regards to fixing the isochrone selection
…sochrone grid and isochrone selection...hopefully now I will have an easier time debugging the this now that the isochrones should at least be correct
|
I guess changing the branch name automatically closed PR #34, which still needs review. |
… that it will make establishing paths less of of a headache
… and run them from light-house-analyses
|
I don't think adding an environment variable is the right way to go. This will mean that users will have to add this as part of the install process which can be annoying. Using relative imports and paths should be able to handle most of these cases. If it is an issue keeping track of where the isochrones are stored, we may want to think about having the user specify where these are stored as an input to the isochrone object instead of trying to hide the lookup tables in the directory structure of the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the branch name to better reflect the work that is actually being done