Add bn256 tests #963
Closed
Add bn256 tests #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoonincode
requested changes
Oct 21, 2024
There was a problem hiding this comment.
bn256 removed its local span when it was updated to require c++20, but the span reference lives on in a few places like
https://github.com/AntelopeIO/bn256/blob/b5adbb76d456e85385296a1388ba18f6f07d9d9e/CMakeLists.txt#L28
and
https://github.com/AntelopeIO/bn256/blob/b5adbb76d456e85385296a1388ba18f6f07d9d9e/src/CMakeLists.txt#L22
the former being what is causing your immediate failure
But I think including the root CMakeLists is going to cause bn256 to become part of the make install target which we want to avoid. That's going to be more invasive to get right
|
@spoonincode thanks for looking into this. I'm going to close this and you or someone else can pick it up later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #962