Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bn256 unit tests are not run as part of spring's build #962

Open
spoonincode opened this issue May 19, 2023 · 1 comment
Open

bn256 unit tests are not run as part of spring's build #962

spoonincode opened this issue May 19, 2023 · 1 comment

Comments

@spoonincode
Copy link
Member

The unit tests from the bn256 library that leap uses are not run as part of leap's build. While the bn256 repo's CI does run these tests, the compilers (and flags) used in that CI may not be the same as we (or individual users) use for building leap. We really should add these tests as part of leap's build.

@heifner heifner removed the triage label May 22, 2023
@heifner heifner transferred this issue from AntelopeIO/leap Oct 21, 2024
@heifner heifner closed this as completed Oct 21, 2024
@heifner heifner reopened this Oct 21, 2024
@heifner heifner closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2024
@heifner heifner reopened this Oct 21, 2024
@heifner heifner changed the title bn256 unit tests are not run as part of leap's build bn256 unit tests are not run as part of spring's build Oct 21, 2024
@heifner heifner self-assigned this Oct 21, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Oct 21, 2024
@heifner heifner added this to the Spring v1.1.0-rc1 milestone Oct 21, 2024
heifner added a commit that referenced this issue Oct 21, 2024
@heifner heifner removed their assignment Oct 21, 2024
@heifner heifner removed the OCI Work exclusive to OCI team label Oct 21, 2024
@heifner heifner removed this from the Spring v1.1.0-rc1 milestone Oct 21, 2024
@heifner
Copy link
Member

heifner commented Oct 21, 2024

@spoonincode comment from PR #963

bn256 removed its local span when it was updated to require c++20, but the span reference lives on in a few places like
https://github.com/AntelopeIO/bn256/blob/b5adbb76d456e85385296a1388ba18f6f07d9d9e/CMakeLists.txt#L28
and
https://github.com/AntelopeIO/bn256/blob/b5adbb76d456e85385296a1388ba18f6f07d9d9e/src/CMakeLists.txt#L22
the former being what is causing your immediate failure

But I think including the root CMakeLists is going to cause bn256 to become part of the make install target which we want to avoid. That's going to be more invasive to get right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants