Update various documentation dead links and typos #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
approved these changes
Jul 28, 2022
Comment on lines
-1
to
-10
| Devices | ||
| === | ||
|
|
||
| See: | ||
|
|
||
| * http://api.zeromq.org/2-1:zmq-device | ||
| * `IDevice` and `DeviceBase` | ||
| * `ForwarderDevice` | ||
| * `QueueDevice` | ||
| * `StreamerDevice` |
There was a problem hiding this comment.
I can recover it, it wasn't linked in the sidebar and with the current content, I thought it was an incomplete page to be honest.
I can, I'm not 100% sure how the mkdocs version is resolved through the GitHub Pages mechanism but I can run it locally. Want me to apply the changes so that it works with the latest version of mkdocs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a couple of dead links and typos in the documentation. I removed the 404 links and empty documentation pages.
There's a new version of mkdocs that added a breaking change to the
mkdocs.ymlfile (pages becomes nav)I think the readthedocs hasn't been refreshed/redeployed in a while because there's still an issue with the missing end code block on https://netmq.readthedocs.io/en/latest/message/ that was fixed in #1012