Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid NRE on disposed timers #1011

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

valeriob
Copy link
Contributor

It looks like that using HeartbeatTimers causes a race condition so that timers gets disposed before execution, when it happens the whole process crashes, this only mitigates the problem, I still do not understand why it's happening, but it looks like complicated to debug.

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #1011 (6e2e089) into master (0b58c23) will increase coverage by 65.76%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           master    #1011       +/-   ##
===========================================
+ Coverage        0   65.76%   +65.76%     
===========================================
  Files           0      146      +146     
  Lines           0     9065     +9065     
  Branches        0     1451     +1451     
===========================================
+ Hits            0     5962     +5962     
- Misses          0     2496     +2496     
- Partials        0      607      +607     
Impacted Files Coverage Δ
src/NetMQ/Core/IOObject.cs 96.00% <0.00%> (ø)
src/NetMQ/OutgoingSocketExtensions.cs 76.71% <0.00%> (ø)
src/NetMQ/Core/Utils/YQueue.cs 96.61% <0.00%> (ø)
src/NetMQ/Sockets/SubscriberSocket.cs 42.10% <0.00%> (ø)
src/NetMQ/RoutingKey.cs 9.61% <0.00%> (ø)
src/NetMQ/Core/Utils/PollerBase.cs 100.00% <0.00%> (ø)
src/NetMQ/EmptyArray.cs 100.00% <0.00%> (ø)
src/NetMQ/Core/YPipe.cs 100.00% <0.00%> (ø)
src/NetMQ/Core/Utils/StringLib.cs 0.00% <0.00%> (ø)
src/NetMQ/Core/Reaper.cs 93.61% <0.00%> (ø)
... and 137 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant