Draft edit action #452
Merged
Draft edit action #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppanero
commented
Aug 11, 2023
•
ppanero
commented
- requires actions: add edit draft inveniosoftware/invenio-rdm-migrator#136
- closes migration-actions: Record/draft #428
|
blocked until we have a db fixture able to rollback changes |
ppanero
force-pushed
the
draft-edit-action
branch
from
d7867db
to
946b470
Compare
|
unblocked, code fixed and tests passing in local |
slint
approved these changes
Aug 17, 2023
Comment on lines
+115
to
+140
| # no need to differentiate from record update since we wont do that in support | ||
| # and user edits (e.g. web ui) pass by a draft (create + [edit] + publish actions) |
There was a problem hiding this comment.
comment: indeed that is the case! scrape my comment regarding what I said in the invenio-rdm-migrator PR, edits and updates can be handled in the same action.
added 6 commits
August 17, 2023 11:31
ppanero
force-pushed
the
draft-edit-action
branch
from
a02303d
to
0c7b89c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.