Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migration: file upload action #446

Merged
merged 2 commits into from
Aug 17, 2023
Merged

migration: file upload action #446

merged 2 commits into from
Aug 17, 2023

Conversation

ppanero
Copy link

@ppanero ppanero commented Aug 9, 2023 •
edited
Loading

Tests passing locall with corresponding branches of the required repos
Screenshot 2023-08-09 at 16 48 14

⚠️

review from a94cd18

actions coverage is at a 100%

zenodo_rdm_migrator/actions/__init__.py                              5      0   100%
zenodo_rdm_migrator/actions/drafts.py                               30      0   100%
zenodo_rdm_migrator/actions/files.py                                35      0   100%
zenodo_rdm_migrator/actions/users.py                                78      0   100%

🚀

@ppanero ppanero requested a review from slint August 9, 2023 15:01
@ppanero ppanero force-pushed the file-actions branch 3 times, most recently from 217a21b to 789b7c3 Compare August 11, 2023 14:06
@ppanero
Copy link
Author

ppanero commented Aug 11, 2023

Tests passing locally with latest changes and latest invenio-rdm-migrator (not released yet)

Screenshot 2023-08-11 at 16 16 29

@ppanero ppanero requested review from slint and removed request for slint August 11, 2023 14:16
slint
slint approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@slint slint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Two minor comments, one can be shelved as a new list item in the original issue, since it's an edge case.

migrator/zenodo_rdm_migrator/actions/transform/files.py Show resolved Hide resolved
migrator/zenodo_rdm_migrator/actions/transform/files.py Show resolved Hide resolved
@ppanero ppanero mentioned this pull request Aug 15, 2023
Closed
8 tasks
@ppanero ppanero merged commit 4184bae into zenodo:master Aug 17, 2023
3 checks passed
@ppanero ppanero deleted the file-actions branch August 17, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slint slint slint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migration-actions: Files
2 participants
@ppanero @slint