Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zac boost UI #27

Merged
merged 36 commits into from
Nov 16, 2023
Merged

Zac boost UI #27

merged 36 commits into from
Nov 16, 2023

Conversation

zacharyLYH
Copy link
Owner

No description provided.

Copy link
Contributor

@ES-Legacy ES-Legacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are just more generic things, the code all around looks pretty good, just some of the styling options are a little odd in my opinion. I didn't leave these in code lines, because it's not necessarily all things that you changed, just things that I think should be changed and could improve. Most of these are less code-centric and more just like "take the design a different direction"

NAVBAR

  • I don't think our navbar should have the "getting started" dropdown menu with 3 options. We don't have many options to begin with, so I think it's always better to just have it spread out across the navbar. If we had a ton of options and it was overwhelming the user with information overload, I could see this point being made.

  • Furthermore, the text descriptions of the buttons are a little redundant. "About" and "See what TailSpin About", the description doesn't really add anything to any of these, and the buttons are self-explanatory.

  • "Let's Write Some Code" should just be "Code", I understand or I think that you were going for making it seem more fun, but that's just an unusual choice to throw that in the navigation menu.

  • The "Getting Started" button is practically touching the tailspin logo

Hero Page

  • Get rid of "Developer Centric" that just feels extra
  • I'd probably make the animation piece last slightly longer at each stage for people slow to read
  • In the animation, "Free to Play" should probably be "Free to Use"

About

  • Should probably be a whole page length/height despite not having that much content to go on it, or atleast a bit longer. The second you get there, you already see the stepper form
  • Just noticed this but in the top left box you wrote "revolutioned" but I think that's meant to be "revolutionized"

Stepper

  • Why the white background? Bro hurt my eyes switching from black to white :(
  • This might've been a me thing when I made the stepper, but I see you made some small changes to it, but I think the form size shouldn't decrease when moving to step 2

Stats/TimeLine

  • I think the boxes should be same height
  • I think that the headers for the boxes should be the same size
  • The timeline box shouldn't stretch to the end of the screen
  • Stats needs some more changes in general, I can figure something out to that end soon though.

Useless Info

  • The FAQ is useless information?
  • Maybe this also shouldn't be combined in the way that it is

Rate/Review

  • Just noticed this, but maybe the give us more feedback button should have two changes. One should be either remove the optionally or put optionally at the end and say (optional) instead. The other should be that when hovering over the button there should be a color change, or animation or something, like most of our other buttons have

Footer

  • Should stretch the whole screen width and reach bottom of screen, left a comment on footer section, but it's just a m-4 in class-name that's preventing this

@ES-Legacy
Copy link
Contributor

Waiting on fixes to the "some useless information" and "statistics" boxes not being completely responsive to screen sizes and overflowing the boxes.

Copy link
Contributor

@ES-Legacy ES-Legacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, I am taking over the fixes and working on the UI in some new prs.

@ES-Legacy ES-Legacy merged commit 9289ffb into dev Nov 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants