Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo: Improve animation performance. #296

Merged
merged 1 commit into from
Feb 18, 2015
Merged

Demo: Improve animation performance. #296

merged 1 commit into from
Feb 18, 2015

Conversation

nicksay
Copy link
Contributor

@nicksay nicksay commented Feb 18, 2015

  • Use GPU-accelerated properties when animating.
  • Make minor overall style adjustments.

@nicksay
Demo: Improve animation performance.
e7b1f0e 
- Use GPU-accelerated properties when animating.
- Make minor overall style adjustments.
@nicksay nicksay mentioned this pull request Feb 18, 2015
Merged
@awbraunstein
Copy link
Contributor

Does this include that jank fix?

@nicksay
Copy link
Contributor Author

nicksay commented Feb 18, 2015

Yes, the previous version had top: 5%, and that value was subtly changing during the content reparenting. I changed it to top: 2em, which stays fixed.

@awbraunstein
Copy link
Contributor

lgtm

nicksay added a commit that referenced this pull request Feb 18, 2015
@nicksay
Merge pull request #296 from nicksay/demo-animation
6deb36e 
Demo: Improve animation performance.
@nicksay nicksay merged commit 6deb36e into youtube:master Feb 18, 2015
@nicksay nicksay deleted the demo-animation branch February 18, 2015 21:07
@nicksay
Copy link
Contributor Author

nicksay commented Feb 23, 2015

Post-commit associating this with #299.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicksay @awbraunstein