Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix frequencies missing value to push to array #1476

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix frequencies missing value to push to array #1476

merged 1 commit into from
Oct 10, 2024

Conversation

Kuuuube
Copy link
Member

@Kuuuube Kuuuube commented Oct 10, 2024

Oops (#1437)

@Kuuuube Kuuuube added kind/bug The issue or PR is regarding a bug area/anki The issue or PR is related to Anki integration labels Oct 10, 2024
@Kuuuube Kuuuube requested a review from a team as a code owner October 10, 2024 00:39
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 10, 2024

CodSpeed Performance Report

Merging #1476 will improve performances by 18.95%

Comparing Kuuuube:fix-frequency-handlebars (f9831cd) with master (73793a4)

Summary

⚡ 1 improvements
✅ 4 untouched benchmarks

Benchmarks breakdown

Benchmark master Kuuuube:fix-frequency-handlebars Change
⚡ spanish transformations (n=97) 14.2 ms 11.9 ms +18.95%

@Kuuuube Kuuuube added priority/high High priority issue/PR regression This issue or PR is related to a regression labels Oct 10, 2024
MarvNC
MarvNC approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@MarvNC MarvNC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gz

@Kuuuube Kuuuube added this pull request to the merge queue Oct 10, 2024
Merged via the queue into yomidevs:master with commit 17f76ba Oct 10, 2024
11 checks passed
@Kuuuube Kuuuube deleted the fix-frequency-handlebars branch October 10, 2024 00:50
jamesmaa pushed a commit that referenced this pull request Oct 14, 2024
@Kuuuube @jamesmaa
Fix frequencies missing value to push to array (#1476)
142644b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvNC MarvNC MarvNC approved these changes

Assignees
No one assigned
Labels
area/anki The issue or PR is related to Anki integration kind/bug The issue or PR is regarding a bug priority/high High priority issue/PR regression This issue or PR is related to a regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kuuuube @MarvNC