Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scanHyperlinkText option #1426

Closed
wants to merge 2 commits into from

Conversation

khaitruong922
Copy link

Enhancement request from #1418

@khaitruong922 khaitruong922 requested a review from a team as a code owner September 17, 2024 16:29
Copy link

github-actions bot commented Sep 17, 2024

⚠️ Visual differences introduced by this PR; please validate if they are desirable.

View Playwright Report (note: open the "playwright-report" artifact)

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Sep 17, 2024
@khaitruong922 khaitruong922 changed the title Add scanHyperlink option Add scanHyperlinkText option Sep 17, 2024
@Kuuuube
Copy link
Member

Kuuuube commented Sep 20, 2024

I wonder if this should be something like "scanInteractiveElements" instead. And include buttons and whatnot. Since that would have the same potentially unwanted scanning.

@jamesmaa
Copy link
Collaborator

Why does this have to be a configurable option? Can we just decide on one behavior that covers 80% of what people want?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants