Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP #17 Rultor Simulator #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tannakartikey
Copy link

@tannakartikey tannakartikey commented Nov 21, 2017

@yegor256 I have created PR so that you can evaluate if I am going on the right track or not. Also, I have some questions.

First I will explain what I am doing:

Whenever @rultor is mentioned in the talk it starts a new daemon with variables like head, head_branch, author etc. Then first run.sh is executed followed by _head.sh. Which later starts the docker container.

According to my implementation, Rultor::Deploy#run, the .rultor.yml file will be read and loaded. Then directly the docker container will start. Things like setting the git config, cloning the repo(if required) will be done using customized entry.sh which is extracted from _head.sh

Is it the right way to do it? Or we can do it better?

I have the following question:

  • While configuring Rultor using Github we give access to it of the code repo and the assets repo. How to share this access with rultor-remote.
    One option to give Rultor access to code is to mount the current directory(assuming it is being run from the project's home directory). How to access the private assets repository?
    Is it a good idea to mount current directory in docker container?

@0crat
Copy link

0crat commented Nov 21, 2017

@yegor256 please, pay attention to this pull request

@0crat
Copy link

0crat commented Nov 21, 2017

Job gh:yegor256/rultor-remote#19 is in scope.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e3e0463 on tannakartikey:17 into e1e4926 on yegor256:master.

@0crat
Copy link

0crat commented Apr 12, 2018

@yegor256/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually or invite more people to the project, as explained in §51

@0crat
Copy link

0crat commented Apr 17, 2018

@yegor256/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually or invite more people to the project, as explained in §51

@0crat
Copy link

0crat commented Apr 22, 2018

@yegor256/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually or invite more people to the project, as explained in §51

@0crat
Copy link

0crat commented Apr 27, 2018

@yegor256/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link

0crat commented May 3, 2018

@yegor256/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@yegor256 yegor256 self-assigned this May 6, 2018
@yegor256
Copy link
Owner

yegor256 commented May 6, 2018

@tannakartikey what entry.sh is doing here? I believe, it's in this PR by mistake

@0crat
Copy link

0crat commented May 6, 2018

The job #19 assigned to @yegor256/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

@0crat
Copy link

0crat commented May 6, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @yegor256/z

@yegor256 yegor256 removed their assignment Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants