refactor: commentController 변경 (#71)

xxoznge · Jul 4, 2024 · ad5953e · ad5953e
1 parent 81aca25
commit ad5953e
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 8 deletions.
diff --git a/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/controller/CommentController.java b/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/controller/CommentController.java
@@ -1,6 +1,5 @@
 package com.ddabong.ddabongdotchiBE.domain.comment.controller;
 
-import java.util.Collections;
 import java.util.List;
 
 import org.springframework.web.bind.annotation.GetMapping;
@@ -42,10 +41,6 @@ public ApiResponse<CommentCreateResponse> createComment(
 
 	@GetMapping("/{cardId}")
 	public ApiResponse<List<CommentGetResponse>> getComment(@PathVariable Long cardId) {
-		List<CommentGetResponse> commentResponses = commentQueryService.getComment(cardId);
-		if (!commentResponses.isEmpty()) {
-			return ApiResponse.onSuccess(commentResponses);
-		}
-		return ApiResponse.onSuccess(Collections.emptyList());
+		return ApiResponse.onSuccess(commentQueryService.getComment(cardId));
 	}
 }
diff --git a/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/service/CommentQueryService.java b/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/service/CommentQueryService.java
@@ -20,7 +20,7 @@ public class CommentQueryService {
 	public List<CommentGetResponse> getComment(Long cardId) {
 		return commentRepository.findByCardIdOrderByCreatedAtDesc(cardId)
 			.stream()
-			.map(comment -> CommentGetResponse.from(comment))
+			.map(CommentGetResponse::from)
 			.toList();
 	}
 }
diff --git a/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/service/CommentService.java b/src/main/java/com/ddabong/ddabongdotchiBE/domain/comment/service/CommentService.java
@@ -29,7 +29,6 @@ public CommentCreateResponse createComment(
 		User authUser,
 		CommentCreateRequest request
 	) {
-
 		Card card = cardRepository.findById(request.cardId())
 			.orElseThrow(() -> new CardExceptionHandler(CardErrorCode.CARD_NOT_FOUND));