Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-20782: Display the breadcrumb on access denied pages #3554

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Oct 10, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-20782

Changes

Description

  • Added the hierarchy template at the usual place.

Clarification

Screenshots & Video

before the PR:
Screenshot from 2024-10-10 17-55-25
after the changes proposed in this PR:
Screenshot from 2024-10-10 17-55-39

Executed Tests

None

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • None, low priority improvement.

* Added the hierarchy template at the usual place.
@Sereza7
Copy link
Contributor Author

Sereza7 commented Oct 10, 2024

@michitux
Technically this PR shows more info to the user lacking rights than they used to have. Is this still okay on the scope of security?

@manuelleduc
Copy link
Contributor

Technically this PR shows more info to the user lacking rights than they used to have. Is this still okay on the scope of security?
Document references are not considered sensitive information. If it's the only thing we provide, that's ok from a security point of view.

@michitux michitux merged commit 39aefcb into xwiki:master Oct 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants