[TBD] - Refactoring of dataeditor.js #3528
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surli
force-pushed
the
refactoring-dataeditors
branch
4 times, most recently
from
aab96a1
to
7ed3418
Compare
surli
force-pushed
the
refactoring-dataeditors
branch
from
7ed3418
to
2eff5e9
Compare
surli
commented
Oct 7, 2024
| var xclassName = this.getXClassNameFromXObjectId(object.id); | ||
| var addedObjects = this.editorStatus.addedXObjects[xclassName]; | ||
| notification.replace(new XWiki.widgets.Notification(l10n['core.editors.object.add.done'], "done")); | ||
| xm.refreshVersion(); |
There was a problem hiding this comment.
We don't need to call a refresh version each time an object is added anymore, since we only save the added object when clicking on save button, which should trigger the refresh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Introduction of action in meta.js
Refactoring of dataeditors.js to get rid of prototype and to use xm.action for performing AJAX requests.
Jira URL
Changes
Description
Clarifications
Screenshots & Video
Executed Tests
Expected merging strategy
*