Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XWIKI-21884: Uploading files during page creation step will mark XWikiGuest as creator #2885

Merged
merged 2 commits into from
Feb 23, 2024
Merged

XWIKI-21884: Uploading files during page creation step will mark XWikiGuest as creator #2885

merged 2 commits into from
Feb 23, 2024

Conversation

oanalavinia
Copy link
Contributor

Jira URL

https://jira.xwiki.org/browse/XWIKI-21884

Changes

Description

  • check if the document where the current attachment is created is actually a new document and set the creator in this case

Clarifications

Screenshots & Video

Before:

createdByGuestUser

After:

guestUserCreatorAfter

Executed Tests

Run mvn clean install -Pquality,integration-tests,docker in module xwiki-platform-rest.

Expected merging strategy

  • Prefers squash: Yes
  • Backport on branches:
    • stable-15.10.x

@manuelleduc manuelleduc added the backport stable-15.10.x Used for automatic backport to 15.10.x branch. label Feb 14, 2024
manuelleduc
manuelleduc reviewed Feb 14, 2024
View reviewed changes
Copy link
Contributor

@manuelleduc manuelleduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but I'd suggest adding a unit test along your change.

@oanalavinia
XWIKI-21884: Uploading files during page creation step will mark XWik…
68072ac 
…iGuest as creator

* adjust unit test to verify also creator
@oanalavinia
Copy link
Contributor Author

I adjusted an existing unit test to verify the creator of the page as well. It was assuming XWikiGuest before

@surli surli merged commit 9b1251a into xwiki:master Feb 23, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Feb 23, 2024
@oanalavinia @github-actions
XWIKI-21884: Uploading files during page creation step will mark XWik…
a2384a7 
…iGuest as creator (#2885)

* set the page creator
* adjust unit test to verify also creator

(cherry picked from commit 9b1251a)
@github-actions github-actions bot mentioned this pull request Feb 23, 2024
Merged
surli pushed a commit that referenced this pull request Feb 23, 2024
@oanalavinia @surli
XWIKI-21884: Uploading files during page creation step will mark XWik…
03c3623 
…iGuest as creator (#2885)

* set the page creator
* adjust unit test to verify also creator

(cherry picked from commit 9b1251a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelleduc manuelleduc manuelleduc left review comments

Assignees
No one assigned
Labels
backport stable-15.10.x Used for automatic backport to 15.10.x branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oanalavinia @manuelleduc @surli