Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-21775: Admin section: make the name strategy section pass webstandard tests #2797

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

Sereza7
Copy link
Contributor

@Sereza7 Sereza7 commented Jan 16, 2024

Jira URL

https://jira.xwiki.org/browse/XWIKI-21775

Changes

Description

  • Fixed the for attribute of a label
  • Removed the comment from the test for WYSIWYG

Clarifications

  • The label must have been copy/pasted too fast and not properly tested afterwards, because it pointed towards the same input field as its predecessor. Once the cause of this error was figured out, it was a pretty straightforward fix.

Executed Tests

  • Successfully passed mvn clean install -f xwiki-platform-distribution/xwiki-platform-distribution-flavor/xwiki-platform-distribution-flavor-test/xwiki-platform-distribution-flavor-test-webstandards -Dxwiki.test.startXWiki=false after updating the live distribution with the changes in this PR.

Expected merging strategy

  • Prefers squash: Yes
  • Only on master.

…andard tests

* Fixed a `label` copy pasted too fast: the for attribute did not get updated.
* Removed the comment from the test for WYSIWYG
@surli surli merged commit ab206bc into xwiki:master Jan 18, 2024
vmassol pushed a commit that referenced this pull request Jan 18, 2024
…andard tests (#2797)

* Fixed a `label` copy pasted too fast: the for attribute did not get updated.
* Removed the comment from the test for WYSIWYG
Sereza7 added a commit to Sereza7/xwiki-platform that referenced this pull request Jan 18, 2024
…andard tests (xwiki#2797)

* Fixed a `label` copy pasted too fast: the for attribute did not get updated.
* Removed the comment from the test for WYSIWYG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants