XWIKI-21738: Remove uselocastore/usemainstore configurations for better maintenance #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmortagne
reviewed
Jan 10, 2024
...c/main/java/org/xwiki/notifications/filters/migration/R160000001XWIKI21738DataMigration.java
Outdated
Show resolved
Hide resolved
tmortagne
reviewed
Jan 10, 2024
...orm-tools/xwiki-platform-tool-configuration-resources/src/main/resources/xwiki.properties.vm
Show resolved
Hide resolved
surli
force-pushed
the
XWIKI-21738
branch
2 times, most recently
from
a22992c
to
9d2134e
Compare
…er maintenance Start refactoring by removing entirely NotificationFilterPreferenceConfiguration since it's now useless. Remove also calls to useMainStore/useLocalStore where needed and fix tests. Started to define migration but not implemted yet. WIP: migration not yet impleemnted and coverage failing.
…er maintenance * Provide migration of filters WIP: coverage still failing
…er maintenance * Remove options from configuration
…er maintenance * Fix migration issue
…er maintenance * Bulletproof a bit the migration * Fix property file
…er maintenance * Provide unit test for the migration
…er maintenance * Improve unit test
manuelleduc
reviewed
Feb 13, 2024
...rs-default/src/main/java/org/xwiki/notifications/filters/internal/DocumentMovedListener.java
Outdated
Show resolved
Hide resolved
…m-notifications-filters/xwiki-platform-notifications-filters-default/src/main/java/org/xwiki/notifications/filters/internal/DocumentMovedListener.java Co-authored-by: Manuel Leduc <manuel.leduc@xwiki.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/XWIKI-21738
Changes
Description
Remove uselocalstore and usemainstore from the xwiki.properties: the goal is to always rely on uselocalstore: i.e. to have always the filters located in same DB as the owner of the filter.
Provide a migration to move all filters that are stored in main DB in subwiki DBs based on their owner.
Clarifications
Remove entirely NotificationFilterPreferenceConfiguration since it's now useless. Remove also calls to useMainStore/useLocalStore where needed and fix tests.
Executed Tests
mvn clean install -Pquality,integration-tests,dockerran on modulexwiki-platform-notification.Manual migration tests: TBD
Expected merging strategy