XWIKI-18007: Drawer menu improvements for accessibility #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelleduc
reviewed
Feb 4, 2023
...amingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/javascript.vm
Outdated
Show resolved
Hide resolved
manuelleduc
reviewed
Feb 4, 2023
...amingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/javascript.vm
Outdated
Show resolved
Hide resolved
mflorea
requested changes
Feb 9, 2023
...amingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/javascript.vm
Outdated
Show resolved
Hide resolved
Comment on lines
206
to
212
| // Drawer can be closed by pressing the ESC key, regardless of how it was opened, whether by keyboard or clicking. | ||
| $(document).on('keydown', function (event) { | ||
| if (event.key === 'Escape') { | ||
| $('.drawer-nav') | ||
| .closest('body') | ||
| .drawer('close'); | ||
| } |
There was a problem hiding this comment.
We should limit javascript.vm for JavaScript code that needs to be executed very early. The rest of the JavaScript code should be put in dedicated JavaScript files. In this case I'd move the entire RequireJS block that handles the drawer to flamingo.js.
Moved the code responsible for drawer to the flamingo.js file Fixed formatting
wthrajat
force-pushed
the
issue-18007
branch
from
db4383f
to
0e06788
Compare
|
This PR doesn't fix the mentioned Jira issue but only a small part of it. Missing parts from what I can see are:
It is fine to just fix closing the drawer, but I think for this, a new Jira issue should be created that can be closed after this has been merged while the original issue should stay open until everything has been fixed. |
|
Closing as the work as been done in #2225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partly fix the issue https://jira.xwiki.org/browse/XWIKI-18007
The drawer menu can now be closed by pressing the
ESCkey (this works for both the cases, 1) if you opened the drawer using keyboard 2) if you opened the drawer by clicking on it)Earlier there was no such option to close the drawer menu through keyboard.