Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdjwt vcdm #89

Merged
merged 14 commits into from
Oct 9, 2024
Merged

Sdjwt vcdm #89

merged 14 commits into from
Oct 9, 2024

Conversation

kkmanos
Copy link
Member

@kkmanos kkmanos commented Oct 8, 2024

No description provided.

@kkmanos kkmanos marked this pull request as ready for review October 9, 2024 09:15
@pstamatop
Copy link
Contributor

do we need all those images in ehic's public/?

@gkatrakazas
Copy link
Member

do we need all those images in ehic's public/?

No, we actually only need one svg image. However, when I add just that one image, the existing images from the wallet-enterprise get overwritten and lost, and this issue occurs across all issuers. It seems like we may need to refactor parts of the code responsible for handling file overwrites to ensure that only the necessary images are added or updated without affecting other existing files.

@kkmanos kkmanos merged commit c8705f7 into master Oct 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants