feat: Needs to improve file upload, add tests to demo the failure with complex input #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added 2 tests. The first one is the regular scenario where one have a variable for normal uploads. The second is a failing test which show a validation problem when you have a complex input in GQL, an input which the
Uploadscalar is an internal field from the input.I am debugging the internal to solve this. I'm afraid my past solution was not ideal. I introduced a fix that solved the problem earlier, but it feels like a hack:
https://github.com/wundergraph/graphql-go-tools/pull/758/files#diff-8a6f211adbdd8b7c97282d713fa1eb60e673f77b26464efd67bc27e7ddde5460L133
Any guidance here is much appreciated.